Skip to content

OCPBUGS-65959: Revert "OCPBUGS-50492: Add kube_rbac_proxy service" #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Dec 2, 2025
Merged

OCPBUGS-65959: Revert "OCPBUGS-50492: Add kube_rbac_proxy service" #5445

openshift-merge-bot merged 1 commit into from
Dec 2, 2025

Conversation

@yuqi-zhang
Copy link
Contributor

@yuqi-zhang yuqi-zhang commented Nov 25, 2025

This reverts commit 3ccd953, as it broke the rbac-proxy pod entirely. See bug for details

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Nov 25, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 25, 2025

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-65959, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This reverts commit 3ccd953, as it broke the rbac-proxy pod entirely. See bug for details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 25, 2025
@openshift-ci openshift-ci bot requested review from djoshy and umohnani8 November 25, 2025 21:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Nov 25, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 25, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 25, 2025

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-65959, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr November 25, 2025 21:56
@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Nov 25, 2025

cc @shirmoran @juzhao

@yuqi-zhang yuqi-zhang mentioned this pull request Nov 25, 2025
Open
@juzhao
Copy link

juzhao commented Nov 26, 2025

/retest-required

@umohnani8
Copy link
Contributor

umohnani8 commented Dec 1, 2025

/lgtm
/verified

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2025

@umohnani8: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

In response to this:

/lgtm
/verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [umohnani8,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djoshy
Copy link
Contributor

djoshy commented Dec 1, 2025

@juzhao would you like to per merge verify this PR before adding the verified tag or would you prefer to do that post-merge?

@umohnani8
Copy link
Contributor

umohnani8 commented Dec 1, 2025

bypassing verified as it is a revert

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 1, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2025

@umohnani8: The verified label has been added.

In response to this:

bypassing verified as it is a revert

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@umohnani8
Copy link
Contributor

umohnani8 commented Dec 1, 2025

@djoshy apologies, I didn't see your comment before adding the verified later. Given that this is a revert and a bit of an urgent bug, I thought it would be okay to bypass the verification

@djoshy
Copy link
Contributor

djoshy commented Dec 1, 2025

no worries, I don't think the revert should hurt, and it can be tested post merge too 😄

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2025

/retest-required

Remaining retests: 0 against base HEAD efc86f6 and 2 for PR HEAD e9ed0e8 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 8649284 and 1 for PR HEAD e9ed0e8 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025 •
edited
Loading

@yuqi-zhang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit e9ed0e8 link false /test bootstrap-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Dec 2, 2025

/override ci/prow/e2e-gcp-op-single-node

passed twice previously, got unlucky on the last run

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op-single-node

In response to this:

/override ci/prow/e2e-gcp-op-single-node

passed twice previously, got unlucky on the last run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 4a64f2f into openshift:main Dec 2, 2025
13 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@yuqi-zhang: Jira Issue Verification Checks: Jira Issue OCPBUGS-65959
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65959 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This reverts commit 3ccd953, as it broke the rbac-proxy pod entirely. See bug for details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djoshy djoshy Awaiting requested review from djoshy

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@umohnani8 umohnani8

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yuqi-zhang @openshift-ci-robot @juzhao @umohnani8 @djoshy